Implemented spaces in author name breaks author page

[dethfire]

3. Change slug author URL to Custom

Any options I set doesn't save. It reverts back to whatever the default is. hmmm

 

[Gracie]

The only option in XenWord is to turn on / off access to the user panel.

 

[dethfire]

The only option in XenWord is to turn on / off access to the user panel.

I don't know what this is in reference to, but I only have the first option On

 

[Gracie]

The next option is to simply go into the database and edit the user_nicename.

Open phpmyadmin
click on WordPress database for site
click on wp_users
click on Browse
double-click on space for user_nicename
change to "customer-2" style nicename
save
open another browser tab and try /author/customer-2

 

[Gracie]

Just looked at the edit slug plugin and another person posted that it was not saving.

 

[dethfire]

Just looked at the edit slug plugin and another person posted that it was not saving.

That is me

Looking at edit the DB now

 

[dethfire]

The nice username is already "dr-courtney"

wordpress doesn't seem to use it

 

[Gracie]

wordpress doesn't seem to use it

What theme are you using?

 

[dethfire]

http://themeforest.net/item/enfold-responsive-multipurpose-theme/4519990

 

[LPH]

http://themeforest.net/item/enfold-responsive-multipurpose-theme/4519990

Good job @Gracie - this is definitely WordPress at its finest

I purchased the theme, downloaded it, installed it and noticed that the link to the author page is different based on the post versus author page. For example, the space is on the loop for main page but the hyphen is present on the author page itself.

Since you also own the theme, can you ask the developer how to get the link to always show with the user_nicename?

According to a quick search for user_nicename, the getParsedObject appears to pull it. I'm just not sure when they use that method and when it is not used.

public function getParsedObject() {

   if(!$this->posts) {
      return array();
   }

   foreach($this->posts as $key => $val) {
      $ret[$key]['post-id'] = $val->ID;
      $ret[$key]['post-slug'] = $val->post_name;
      $ret[$key]['post-url'] = get_permalink($val->ID);
      $ret[$key]['date-published'] = date(get_option('date_format'), strtotime($val->post_date));
      $ret[$key]['date-modified'] = date(get_option('date_format'), strtotime($val->post_modified));
      $ret[$key]['thumbnail'] = $this->getPostThumb($val->ID);
      $ret[$key]['thumbnail'] = !empty($ret[$key]['thumbnail']) ? $ret[$key]['thumbnail'] : LS_ROOT_URL . '/static/img/blank.gif';
      $ret[$key]['image'] = '<img src="'.$ret[$key]['thumbnail'].'" alt="">';
      $ret[$key]['image-url'] = $ret[$key]['thumbnail'];
      $ret[$key]['title'] = htmlspecialchars(__($val->post_title), ENT_COMPAT | ENT_HTML401 | ENT_SUBSTITUTE);
      $ret[$key]['content'] = wp_strip_all_tags(__($val->post_content));
      $ret[$key]['excerpt'] = $this->getExcerpt();
      $ret[$key]['author'] = get_userdata($val->post_author)->user_nicename;
      $ret[$key]['author-id'] = $val->post_author;
      $ret[$key]['categories'] = $this->getCategoryList($val);
      $ret[$key]['tags'] = $this->getTagList($val);
      $ret[$key]['comments'] = $val->comment_count;
   }

   return $ret;
}

 

[Gracie]

To follow up on what @LPH just posted, check out:

https://www.physicsforums.com/insights/author/rude-man/

Hover over the author to get the the author link and it is correct. Go to the post, and the link is without the hyphen.

It's pure theme based.

Update:
What is cool, is go to https://www.physicsforums.com/insights/modulation-vs-beating-confusion-2/ and you can see that the person with the space in their username who left a comment is correctly going to their profile.

 

[dethfire]

In the meantime, is there a way to do a redirect? I have some links in XF to their WP profiles and that will still break.

 

[LPH]

Yes. I was actually working on a change to the author link filter that is currently in XenWord.

Open class-xenword-author-link.php and replace the xenword_author_link() with the following:

        $xenword_author_user_nicename = get_the_author_meta( 'user_nicename' );
        $xf_author_link =  get_site_url() . '/author/';
        $xenword_author_link = $xf_author_link . str_replace(' ', '-', $xenword_author_user_nicename );

        return $xenword_author_link;

This was working locally - but - your site is much more complex. Let's see what happens.

PS. I had to restart the server because caching wasn't showing the change. You will definitely want to clear any caching.

 

[dethfire]

This was working locally - but - your site is much more complex. Let's see what happens.

hmmm edited and restarted web server with no luck

 

[LPH]

hmmm edited and restarted web server with no luck

Wait. Huh? Oh - my bad. I didn't tell remind you to turn on the option in the XenWord Settings Panel? Or did you ?

Turn on the Author redirect. In 3.0.3.01 there are now two sliders. One will redirect to XenForo and the other does a replace of the space to hyphen.

 

[dethfire]

That worked! I'm not how that logically makes sense to turn on that setting though

 

[dethfire]

I think I'll need an htaccess redirect for the links coming from my XF?

 

[LPH]

That worked! I'm not how that logically makes sense to turn on that setting though

The code I wrote overwrites WordPress default behavior and fixes something put into the WP issues tracker 10 years ago.

 

[LPH]

I think I'll need an htaccess redirect for the links coming from my XF?

What links and is this a different issue?

 

[dethfire]

What links and is this a different issue?

It's not a XW issue, but I have links in user postbit areas that link to their author page. This is generated simply by adding their username to the base author URL. So I need to interrupt and fix the url for those with a space.