Conflict with Rotating Ads add-on

[Chazz Layne]

I've run into a minor conflict between the Rotating Ads add-on, which we use to manage ads in our forums, and XenLate. I'm still in the process of running through the code to troubleshoot, but figured I'd bring it to your attention so you're aware of the problem (and in case anyone has an idea).

The latest articles, banner ads, and the rest of the forum listing load up fine, but while XenLate is active it's causing Rotating Ads to load two banners into the header (instead of the single banner it's set to display). Below are screen caps of what should be displayed, and what happens with XenLate active:



I've already run through the admin to make sure no one is messing with me, and verified the problem is somewhere in one of these two add-ons by toggling XenLate on and off. All other functionality appears to be working perfectly (really loving the XenWord suite BTW ). I'll check back after I've had a chance to try and locate the problem.

 

[LPH]

Please let me know.

 

[Chazz Layne]

I had a few more minutes to do some testing, and it look like it's limited to ads outside XenForo's Main Content area. In our case that's header and footer ads in ad_header and ad_below_bottom_breadcrumb. An ad placed at a spot inside Main Content, such as ad_below_content, is unaffected.

I hid the extra ads with a bit of CSS, but obviously that's a temporary measure: a:nth-of-type(2) {display: none;}

I'm pretty comfortable in PHP, but by no means expert. Still, I've combed through the XenLate code and don't see anything that might cause this there. My hunch is the bug is actually in the Rotating Ads add-on, which hasn't been updated in a few years (and unfortunately has many more lines of code).

 

[LPH]

The model in XenLate isn't really done well; that is, it's a mixture of HTML and pulling from WP. The addon was a quick and dirty move of the old instructions.

I started working on it today and was distracted by Visual Studio for Mac, which didn't install.

Maybe a proper model, template, and controller will help.

 

[LPH]

XenLate 1.1.0 was just released. Please try it and let's see if removing the xen:callback helps.

 

[Chazz Layne]

Unfortunately not, but thanks for the new souped up release!

I looked through the new XenLate code and still don't see anything that might be causing this. The more I look at it the more it seems XenLate may have just exposed [another] bug in Rotating Ads, it wouldn't be the first.

 

[LPH]

Unfortunately not, but thanks for the new souped up release!

You are welcome. Bugs can be a nightmare for the user and developer.